chore(deps): bump actions/cache from 5 to 6 - #1271
Conversation
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughTwo GitHub Actions workflows update their dependency cache step from ChangesWorkflow cache version bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
574a3b6 to
27196c1
Compare
27196c1 to
1c1e9a9
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/operator-cd.yml (1)
29-34: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winIsolate this cache from the PR-target workflow.
.github/workflows/publish-components-for-e2e-tests.ymluses the same~/go/pkg/modkey onpull_request_targetwithallow-unsafe-pr-checkout: true, so an untrusted PR can populate a cache that.github/workflows/operator-cd.ymlmay later restore. Use a workflow-specific key or drop the shared prefix fallback.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/operator-cd.yml around lines 29 - 34, Update the actions/cache configuration in the operator-cd workflow to isolate its Go module cache from the pull_request_target workflow: make the key workflow-specific and remove or scope the shared `${{ runner.os }}-go-` restore prefix so caches cannot be shared across workflows.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/operator-cd.yml:
- Around line 29-34: Update the actions/cache configuration in the operator-cd
workflow to isolate its Go module cache from the pull_request_target workflow:
make the key workflow-specific and remove or scope the shared `${{ runner.os
}}-go-` restore prefix so caches cannot be shared across workflows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 463bd400-559b-4d97-af20-7657eef6aeeb
📒 Files selected for processing (2)
.github/workflows/operator-cd.yml.github/workflows/publish-components-for-e2e-tests.yml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
codeready-toolchain/registration-service(manual) → reviewed against open PR#601dependabot/github_actions/actions/cache-6instead of the default branchcodeready-toolchain/member-operator(manual)codeready-toolchain/api(manual)codeready-toolchain/toolchain-common(manual)codeready-toolchain/host-operator(manual)codeready-toolchain/toolchain-e2e(manual) → reviewed against open PR#1289dependabot/github_actions/actions/cache-6instead of the default branch
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/publish-components-for-e2e-tests.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: test
- GitHub Check: govulncheck
- GitHub Check: GolangCI Lint
- GitHub Check: Build & push operator bundles & dashboard image for e2e tests
🧰 Additional context used
🪛 zizmor (1.26.1)
.github/workflows/operator-cd.yml
[error] 29-29: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): enables caching by default
(cache-poisoning)
🔀 Multi-repo context codeready-toolchain/registration-service, codeready-toolchain/member-operator, codeready-toolchain/toolchain-e2e, codeready-toolchain/api, codeready-toolchain/toolchain-common
Linked repositories findings
registration-service(inspectedrefs/pull/601/head): both.github/workflows/operator-cd.ymland.github/workflows/publish-components-for-e2e-tests.ymlstill useactions/cache@v5. [::codeready-toolchain/registration-service::]member-operator(inspectedrefs/pull/748/head): the corresponding workflows still useactions/cache@v5. [::codeready-toolchain/member-operator::]toolchain-e2e(inspectedrefs/pull/1289/head):.github/workflows/publish-components-for-e2e-tests.ymlstill usesactions/cache@v5. [::codeready-toolchain/toolchain-e2e::]- No related cache-action references were found in
apiortoolchain-common. [::codeready-toolchain/api::] [::codeready-toolchain/toolchain-common::]
These are independent workflow updates; no shared API or cross-repository contract is affected.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Bumps [actions/cache](https://github.com/actions/cache) from 5 to 6. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v5...v6) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
1c1e9a9 to
8f3b0ac
Compare
|
|
/lgtm |



Bumps actions/cache from 5 to 6.
Release notes
Sourced from actions/cache's releases.
... (truncated)
Changelog
Sourced from actions/cache's changelog.
... (truncated)
Commits
55cc834Merge pull request #1768 from jasongin/readonly-cached8cd72fBump@actions/cacheto v6.1.0 - handle cache write error due to RO token2c8a9bdMerge pull request #1760 from actions/samirat/esm_migration_and_package_updatee9b91fdPrettier fixese4884b8Rebuild dist10baf01Fixed licensese39b386Fix test mock return orderb692820PR feedback6074912Rebuild dist bundles as ESM to match type:module5a912e8Fix lint and jest issuesSummary by CodeRabbit